Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add netbsd an openbsd to build tags of process_common.go #24

Merged
merged 2 commits into from
May 20, 2022
Merged

Add netbsd an openbsd to build tags of process_common.go #24

merged 2 commits into from
May 20, 2022

Conversation

kvch
Copy link
Contributor

@kvch kvch commented May 20, 2022 •
edited
Loading

What does this PR do?

This PR adds openbsd and freebsd to the list of build tags protecting process_common.go file.

Why is it important?

Without this change libbeat cannot be crosscompiled on openbsd and freebsd:

2 errors occurred:
 --> openbsd/amd64 error: exit status 2
 Stderr: # github.com/elastic/elastic-agent-system-metrics/metric/system/process
 ../../../../../pkg/mod/github.com/elastic/elastic-agent-system-metrics@v0.3.0/metric/system/process/process_types.go:32:11: undefined: PidState
 ../../../../../pkg/mod/github.com/elastic/elastic-agent-system-metrics@v0.3.0/metric/system/process/process_types.go:161:10: undefined: PidState

 --> netbsd/amd64 error: exit status 2
 Stderr: # github.com/elastic/elastic-agent-system-metrics/metric/system/process
 ../../../../../pkg/mod/github.com/elastic/elastic-agent-system-metrics@v0.3.0/metric/system/process/process_types.go:32:11: undefined: PidState
 ../../../../../pkg/mod/github.com/elastic/elastic-agent-system-metrics@v0.3.0/metric/system/process/process_types.go:161:10: undefined: PidState

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Related issues

Required by elastic/beats#31615

@kvch kvch requested a review from a team as a code owner May 20, 2022 14:57
@kvch kvch requested review from rdner and fearful-symmetry and removed request for a team May 20, 2022 14:57
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 20, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-20T15:00:20.009+0000

  • Duration: 11 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 93
Skipped 2
Total 95

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kvch kvch merged commit a13d6fa into elastic:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvch @elasticmachine @cmacknz